fix casting and unused variable problems on windows #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Jan 27, 2023
examples/tpm_test.h
Outdated
| @@ -103,7 +103,8 @@ static const char pemFileKey[] = "key.pem"; | |||
| extern double current_time(int reset); | |||
| return current_time(reset); | |||
| #elif defined(_WIN32) | |||
| return ((double)GetTickCount64())/1000.0; | |||
| (void)reset; | |||
| return (0.0 + GetTickCount64())/1000.0; | |||
There was a problem hiding this comment.
What was the original error/warning? I don't like the 0.0 workaround. Can you try using the following? return ((double)GetTickCount64())/1000.0F;
There was a problem hiding this comment.
it doesn't like that we're casting the return value of a function, the error was -Werror=bad-function-cast, let me see if it complains if I put it in a variable first
There was a problem hiding this comment.
yeah compiler is fine with it as long as it's stored in a variable fist, should be good now
dgarske
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZD 14996