Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the byte swapping logic for GCC #231

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Improve the byte swapping logic for GCC #231

merged 1 commit into from
Jul 21, 2022

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jul 20, 2022

Fixes ZD 14539

@dgarske dgarske self-assigned this Jul 20, 2022
@dgarske dgarske requested a review from anhu July 20, 2022 22:33
@dgarske dgarske assigned anhu and douzzer and unassigned dgarske and anhu Jul 20, 2022
@dgarske dgarske requested review from douzzer and removed request for anhu July 21, 2022 16:28
douzzer
douzzer approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. built locally, and experimentally confirmed the new gating for gcc __builtins is working.

@douzzer douzzer merged commit 47823ea into wolfSSL:master Jul 21, 2022
@anhu
Copy link
Member

anhu commented Jul 21, 2022

Thanks douzzer!!

@dgarske dgarske deleted the rev64 branch July 22, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douzzer douzzer douzzer approved these changes

Assignees

@douzzer douzzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgarske @anhu @douzzer