Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make install by renaming pcr example read.c #196

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

elms
Copy link

@elms elms commented Nov 18, 2021

example files are installed into the same directory and must have unique names.

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the new read_pcr to the .gitignore?

@elms
Copy link
Author

elms commented Nov 18, 2021

@dgarske This was the quickest solution, but would like to look at keeping the examples in subdirectories when installed. Any thoughts on that?

example files are installed into the same directory and must have
unique names.
@dgarske
Copy link
Contributor

dgarske commented Nov 18, 2021

The make install for me currently generates:

./configure --prefix="`pwd`/myinstall" && make install
% ls -la myinstall/bin
total 528
drwxr-xr-x  8 davidgarske  staff    256 Nov 18 10:24 .
drwxr-xr-x  6 davidgarske  staff    192 Nov 18 10:24 ..
-rwxr-xr-x  1 davidgarske  staff  52840 Nov 18 10:24 keygen
-rwxr-xr-x  1 davidgarske  staff  52120 Nov 18 10:24 keyimport
-rwxr-xr-x  1 davidgarske  staff  51928 Nov 18 10:24 keyload
-rwxr-xr-x  1 davidgarske  staff  51864 Nov 18 10:24 read
-rwxr-xr-x  1 davidgarske  staff  51968 Nov 18 10:24 store
-rwxr-xr-x@ 1 davidgarske  staff   4017 Nov 18 10:24 wolftpm-config

I don't think any apps should be installed with make install. Can you remove those too?

@dgarske dgarske assigned elms and unassigned dgarske Nov 18, 2021
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @elms

@dgarske dgarske merged commit 8ff94c4 into wolfSSL:master Nov 18, 2021
@elms elms deleted the fix/make_install branch November 18, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants