Feature/bump deps main 0402

[ykf173]

20260402合并phi65主分支

[gemini-code-assist]

Code Review

This pull request introduces significant updates to the agentpool codebase, primarily focusing on the integration of the opencode_sdk and the implementation of a new elicitation system. Key changes include the migration to opencode_sdk models, the addition of a MessageReconstructor to handle event stream reconstruction, and the introduction of a SandboxBashTool using bashkit. Additionally, the PR refines the ACP server's session management and configuration handling. My review identified several critical issues regarding type safety in mode validation, incorrect mapping of permission results, and unnecessary type coercion that could break boolean configuration options. Please address these issues to ensure robust and type-safe behavior.

[gemini-code-assist]

The validation logic for mode_id is not type-safe for boolean modes. Since mode_id can be a bool and valid_ids is a set of strings (due to str(m.value)), the membership check mode_id not in valid_ids will always be true for boolean values (e.g., True != "True").

        if matching_category := next((c for c in available_modes if c.id == category_id), None):
            valid_values = {m.value for m in matching_category.available_modes}
            if mode_id not in valid_values:
                raise UnknownModeError(mode_id, sorted(str(v) for v in valid_values))

[gemini-code-assist]

Mapping skip, abort_run, and abort_chain to "allow" is incorrect and potentially dangerous. If a user chooses to skip a tool or abort the run, the agent should not be given permission to execute the tool. These results should map to "deny".

        mapping: dict[ConfirmationResult, Literal["allow", "deny"]] = {
            "allow": "allow",
            "skip": "deny",
            "abort_run": "deny",
            "abort_chain": "deny",
        }

[gemini-code-assist]

This assertion will fail when a boolean configuration option is updated, as value_id will be a bool. The logic should support both str and bool types for current_value.

                assert isinstance(value_id, (str, bool))

[gemini-code-assist]

Boolean configuration options are currently skipped when building native mode categories. This prevents boolean toggles from being exposed in the UI for ACP agents. They should be included as categories with two possible values (True/False).

[gemini-code-assist]

Unnecessary string coercion of current_value. Since ModeCategory.current_mode_id supports str | bool, the value should be passed as-is to preserve type information, especially for boolean config options.

Suggested change

	current_mode_id=str(config_opt.current_value),
	current_mode_id=config_opt.current_value,

[gemini-code-assist]

Coercing value_id to a string here is unnecessary and loses type information for boolean configuration options. Agent.update_state and the underlying ConfigOptionChanged signal both support str | bool values.

Suggested change

	await self._agent.update_state(
	config_id=str(opt.id),
	value_id=str(opt.current_value),
	)
	await self._agent.update_state(
	config_id=opt.id,
	value_id=opt.current_value,
	)