Improve shutdown handling in WebSocket serve functions - #32
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the elicitation system to support distinct 'form' and 'url' modes, updating the schema, request methods, and capability checks. It also simplifies transport connection handling by waiting directly on internal receive tasks and changes several capability fields to be optional by default. Feedback focuses on improving the robustness of the transport layer by removing '.done()' checks that could cause hangs and cautions against accessing private members of external libraries. Additionally, the reviewer recommends ensuring proper null guards are in place for the newly optional capability fields.
…ing .done() checks and adding runtime guards
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the elicitation process by introducing distinct 'form' and 'url' modes, updating the associated schemas and capability checks accordingly. It also simplifies capability defaults to null and adds a validator to handle empty objects for backward compatibility. Feedback was provided regarding the transport layer's reliance on private attributes (_conn and _recv_task), which is considered brittle and violates encapsulation.
2 participants
No description provided.