fix: use one pdf worker for all documents and for all rerenders #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
main
branch
14 times, most recently
from
5e59480
to
41d6126
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
230fd89
to
10ddf61
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
be758b5
to
1a9897f
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
653aa2c
to
9bb8a85
Compare
|
any progress? |
No. This could help with multiple instances of React PDF initialized at the same time only.
There are two main concerns. First - is this still even needed if file-loader is no longer recommended and instead, we pass worker URL to PDF.js? Second - the package has been completely rewritten since so this code isn't compatible with the latest head. Although that's a minor issue, it can easily be rebased. |
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
2d488c1
to
a077571
Compare
wojtekmaj
force-pushed
the
main
branch
5 times, most recently
from
1f758cc
to
ce6db03
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
42a8c3c
to
0d68fee
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
d0aabb2
to
736f3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-pdfv5.3 withfile-loadercreates new worker for all file's change and for allDocumentinstances, so I create a singleton that reuse worker while rerenders and in different documents