Added custom renderer for entire layer #1215
Open
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
36a36d4
to
e249af6
Compare
wojtekmaj
force-pushed
the
main
branch
5 times, most recently
from
26a73cc
to
33ea5de
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
f5a9fd6
to
9243e45
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
fbeabf1
to
240150a
Compare
taneliang
force-pushed
the
ishan-ironclad/customTextLayerRenderer
branch
from
4809c6b
to
8bc03af
Compare
|
Hmmm I'm not against it, think it could be a good addition, but yeah, we'll need docs and tests before this can be merged. I can't take care of this right now. In the meantime, have a look here: #614 (comment) |
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
fc18d18
to
304893b
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
653aa2c
to
9bb8a85
Compare
taneliang
force-pushed
the
ishan-ironclad/customTextLayerRenderer
branch
from
8bc03af
to
bf88495
Compare
wojtekmaj
force-pushed
the
main
branch
7 times, most recently
from
2d488c1
to
a077571
Compare
wojtekmaj
force-pushed
the
main
branch
5 times, most recently
from
1f758cc
to
ce6db03
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
42a8c3c
to
0d68fee
Compare
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
d0aabb2
to
736f3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I had to add a prop to custom-render all text-items at once, rather than one at a time for a search-highlighting use case at the organization I work for. We are looking to search for arbitrary-length phrases on a PDF page, and highlight them if they exist. The main problem being solved here is that longer items of text may be broken up across textLayer items, resulting in many search hits on the document being missed. Seems like this could be a popular use case of this API, so I think it'd be worth it to get this in. Let me know if there's any documentation or testing I'd need to add to get this contribution in.
Thanks!