-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved keyboard navigation/focus handling - Use roving tabindex #799
base: main
Are you sure you want to change the base?
Conversation
Okay, I think this is starting to feel pretty good. I updated a few of the behaviors And I added a whole bunch of tests as well.
I also started to implement aria role="grid", but ran into some breaking-change roadblocks, since the flex layout doesn't actually include any rows. I do think that would be a nice improvement for the future to get it to more properly implement the A couple notes/questions: As part of converting this to use a roving tabindex, I had to convert the |
0f9c665
to
88f5da5
Compare
1f10b65
to
0c5a8da
Compare
@wojtekmaj @thepuzzlemaster Hello, is there any information/update by when this can be released? |
d6fcc20
to
da505dd
Compare
3407450
to
7fc3da6
Compare
9045b27
to
22f61e6
Compare
dc4fd25
to
a8c5ad5
Compare
This PR continues where #449 left off in implementing keyboard navigation using arrow keys.