Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov Upload and Scripts #9

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

appcypher
Copy link
Member

@appcypher appcypher commented Apr 21, 2022

Summary

This PR fixes the following issues

  • Fix codecov upload
  • Fix wnfs helper script

Moving the repo from previous org to the current one broke the codecov upload. This fixes that and also updates the helper script.

Test plan (required)

Manually testing the script.

  • Optional, but you can cd into the project root directory and install the script

    sh scripts/wnfs.sh setup
  • Building the sub projects with the script.

    wnfs build
  • Running all tests with the script.

    wnfs test 

Closing issues

Fixes #8

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7a89949). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   80.42%           
=======================================
  Files           ?       10           
  Lines           ?      567           
  Branches        ?        0           
=======================================
  Hits            ?      456           
  Misses          ?      111           
  Partials        ?        0           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@appcypher appcypher self-assigned this Apr 21, 2022
@appcypher appcypher merged commit 8e59f1f into main Apr 21, 2022
@zeeshanlakhani zeeshanlakhani deleted the appcypher/scripts-and-codecov branch October 19, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov.io Coverage Upload
3 participants