-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private File Sharding #88
Conversation
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 66.05% 67.89% +1.84%
==========================================
Files 26 26
Lines 1903 2003 +100
Branches 486 482 -4
==========================================
+ Hits 1257 1360 +103
- Misses 248 253 +5
+ Partials 398 390 -8
|
Just made our tests slower; enabled Safari and Edge for the wasm-js-tests. We've been ignoring them for a while. I'm considering disabling Edge since we have Chrome tests. |
Made it faster switching to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small things except for the shard order thing :)
- Remove basic heuristic and default to file sharding - Fix shard label generation to conform with spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use array in create_private_file_result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments left, great work.
- Add spec reference to `MAX_BLOCK_CONTENT_SIZE` constant
Summary
This PR implements sharding of file content; breaking the content up and storing them in the HAMT if they are larger than certain threshold, storing them inline otherwise.
This PR implements the following features
Test plan (required)
Testing
rs-wnfs test --all
Closing issues
Fixes #80