-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RatchetKey
to RevisionKey
, encrypt RevisionKey
within PrivateRef
#83
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 66.15% 66.05% -0.10%
==========================================
Files 26 26
Lines 1873 1903 +30
Branches 480 486 +6
==========================================
+ Hits 1239 1257 +18
- Misses 240 248 +8
- Partials 394 398 +4
|
8640f95
to
056298b
Compare
Flipped this to 'ready for review'. No more merge conflicts & no more rogue changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor naming thing that matters very little, 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #77
This also renames
RatchetKey
toRevisionKey
, to be more in line with the terminology from the spec.The
RevisionKey
withinPrivateRef
s in directories is meant to be encrypted with the directory'sRevisionKey
.