Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RatchetKey to RevisionKey, encrypt RevisionKey within PrivateRef #83

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

matheus23
Copy link
Member

Closes #77

This also renames RatchetKey to RevisionKey, to be more in line with the terminology from the spec.

The RevisionKey within PrivateRefs in directories is meant to be encrypted with the directory's RevisionKey.

@matheus23 matheus23 requested a review from a team as a code owner November 3, 2022 14:23
@matheus23 matheus23 marked this pull request as draft November 3, 2022 14:37
@matheus23
Copy link
Member Author

Messed up the branching & merging. Please stand by while I fix this PR

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #83 (facd248) into main (ce7d988) will decrease coverage by 0.09%.
The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   66.15%   66.05%   -0.10%     
==========================================
  Files          26       26              
  Lines        1873     1903      +30     
  Branches      480      486       +6     
==========================================
+ Hits         1239     1257      +18     
- Misses        240      248       +8     
- Partials      394      398       +4     
Impacted Files Coverage Δ
wnfs/src/private/hamt/node.rs 65.64% <ø> (-0.62%) ⬇️
wnfs/src/public/directory.rs 69.96% <50.00%> (ø)
wnfs/src/public/file.rs 73.52% <50.00%> (ø)
wnfs/src/private/node.rs 68.91% <65.71%> (-0.46%) ⬇️
wnfs/src/private/directory.rs 72.50% <66.66%> (-0.33%) ⬇️
wnfs/src/private/file.rs 68.57% <66.66%> (ø)
wnfs/src/private/forest.rs 56.33% <100.00%> (ø)

@matheus23 matheus23 force-pushed the matheus23/encrypted-ratchet-key branch from 8640f95 to 056298b Compare November 3, 2022 14:44
@matheus23 matheus23 marked this pull request as ready for review November 3, 2022 14:49
@matheus23
Copy link
Member Author

Flipped this to 'ready for review'. No more merge conflicts & no more rogue changes.

wnfs/src/private/node.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor naming thing that matters very little, 👍🏽

wnfs/src/private/directory.rs Outdated Show resolved Hide resolved
Copy link
Member

@appcypher appcypher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@matheus23 matheus23 merged commit 80dbe82 into main Nov 4, 2022
@matheus23 matheus23 deleted the matheus23/encrypted-ratchet-key branch November 4, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix temporal encryption scheme
3 participants