Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update README & enhance setup script #65

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

thaodt
Copy link
Contributor

@thaodt thaodt commented Sep 28, 2022

Summary

This PR tries to resolve the issue posted yesterday.

This PR fixes/implements the following bugs/features

  • [ x ] Bug 1: typo error in README.md line 193 script/
  • [ x ] Bug 2: Running build rs-wnfs build --all get wasm-opt command not found.
  • [ x ] Feature: enhance setup script rs-wnfs.sh, try to make use of superuser privileges when creating a symlink.

Test plan (required)

  • remove /usr/local/bin/rs-wnfs.
  • rerun script by command sh scripts/rs-wnfs.sh setup and you should see the result:
    image

Closing issues

Fixes #63

After Merge

  • Does this change invalidate any docs or tutorials? If so ensure the changes needed are either made or recorded
  • Does this change require a release to be made? Is so please create and deploy the release

@codecov-commenter
Copy link

Codecov Report

Merging #65 (f4beee0) into main (0228c17) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   77.28%   77.14%   -0.15%     
==========================================
  Files          26       26              
  Lines        1422     1422              
==========================================
- Hits         1099     1097       -2     
- Misses        323      325       +2     
Impacted Files Coverage Δ
crates/fs/private/hamt/pointer.rs 68.96% <0.00%> (-3.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thaodt
Copy link
Contributor Author

thaodt commented Sep 29, 2022

@appcypher @matheus23 hmm, is it normal when I just changed the bash script but codecov checked rust files? 👀

@matheus23
Copy link
Member

Don't worry about the coverage checks :) They run on every PR AFAIK.

Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! :)

We may move away from shellscript-based build scripting to something else in the future, but in the mean time this is really helpful 👍

@matheus23 matheus23 merged commit 2358c03 into wnfs-wg:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some minors issues while following README
3 participants