-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Share
struct, add documentation, add rc
constructor variants
#343
Conversation
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 57.08% 56.83% -0.25%
==========================================
Files 45 45
Lines 3346 3336 -10
Branches 836 833 -3
==========================================
- Hits 1910 1896 -14
- Misses 874 883 +9
+ Partials 562 557 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan of most changes, just not a big fan of saving a bunch of characters with the rc
name.
Wdyt about new_rc
? Or perhaps an rc
function with the signature fn rc(self) -> Rc<Self>
? So it's &mut PrivateDirectory::new(...).rc()
(perhaps that's too easy to miss in examples though)?
Thought about making an |
hmm I see. I'd argue What do you think of calling the function Also. Perhaps worth trying this out: How crazy would it be if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses some of the #315
Share
struct, add documentation, add rc
constructor variants
@matheus23 Thanks for fixing 👍. Was going to get to it today. |
Summary
This PR adds and updates existing documentation, doc tests and makes other API clean ups.
Test plan (required)
Testing the code.
scripts/wnfs.sh test
Closing issues