Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #20

Closed
wants to merge 4 commits into from
Closed

Update #20

wants to merge 4 commits into from

Conversation

schmurfy
Copy link

I updated the gem to use the latest leveldb version directly from the google git repository.

This fix the "Symbol not found: __ZN6snappy19MaxCompressedLengthEm" problem for me on mac os x lion.

@wmorgan
Copy link
Owner

wmorgan commented Apr 21, 2012

Awesome. I will merge this in once I have a chance to do a little testing. Thank you.

@wmorgan
Copy link
Owner

wmorgan commented Apr 22, 2012

After playing around with it some, I'm not sure this is a good idea.

For one, currently I have to tweak the leveldb Makefile every time I update the code. See e.g. commits efd37b4 and b93c383. We'd have to find an equivalent thing when that code is checked out in a submodule. Every solution I can think of is very complex, but maybe you have a simple option.

And the the 'rake gem' task is going to have to do some work to ensure that the code is in the submodule dir, otherwise we risk shipping gems with missing pieces if you don't remember to do the magic submodule incantation.

@schmurfy
Copy link
Author

Latest leveldb allow to redefine $OPT which allows this:

OPT="-O2 -DNDEBUG -fPIC" make all

I am not sure how to integrate this into the build process but it would allow compiling untouched sources which is always better (and make upgrades so much easier too).

For the submodule a simple approach could be to add a "git submodule update --init" before building the gem, "git submodule" also show you if the submodules are up to date or not so a check should be possible.

For the first point I have no idea how to do in your build process but for the later I can have a look if you want.

@wmorgan
Copy link
Owner

wmorgan commented Jun 26, 2012

Closing this out.

I've updated master to use the OPT trick. Thanks! I think I'm going to stick with manual updates for the time being, though.

I've updated the code to leveldb 1.5. Please reopen if you are still having this issue.

@wmorgan wmorgan closed this Jun 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants