-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce paths #472
Comments
https://github.com/wmo-im/tt-wigosmd/wiki/2023.04.06-TT-WIGOSMD notes:
|
I added columns to 1-01* and 5-02* tables and rebased other active branches. Content still needs to be adjudicated. |
@fstuerzl Are the paths used in OSCAR for ObservingMethods? |
@amilan17 yes, the paths are also used for methods in the same way as for the variables (and programs). In the internal reference table for methods, all entries have a parent method, so that a hierarchical structure can be build up: |
questions/notes for discussion at meeting:
|
1-01-03
|
1-01-05 Need to determine how to organize paths with new labels associated with hydrological variables.
The paths could be:
and the following can remain as tags: watershed, reservoir, aquifer, stream, liquidPhase |
1-01-01
|
Hi Anna
Apologies for the late reply.
I checked also with Franziska and we both don’t see the need for the parameter name in the path.
From: Anna Milan ***@***.***>
Sent: Thursday, April 13, 2023 4:00 PM
To: wmo-im/wmds ***@***.***>
Cc: Cappelletti Lucia ***@***.***>; Mention ***@***.***>
Subject: Re: [wmo-im/wmds] Reintroduce paths (Issue #472)
@fstuerzl<https://github.com/fstuerzl> @luciacap<https://github.com/luciacap>
Does the path need to include the parameter name? For example, can it just be
\Atmosphere\Temperature
instead of
\Atmosphere\Temperature\Air temperature (at specified distance from reference surface)
—
Reply to this email directly, view it on GitHub<#472 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIPTXM225QGX2QTXYY75E6LXBABHPANCNFSM6AAAAAAWNB6ETQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
+1 for listing everything except the variable name itself in the path. If handled in this way, we must assure that it is handled the same way throughout the repo. As paths are not included in the codes registry, I consider this a purely technical change that doesn't need to be listed in the FT amendment. Agreed? |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.04.21-TT-WIGOSMD note: |
If I recall correctly, the previous ad-hoc team on ACV has concluded that 'aerosol' should be turned into 'particlce phase'; and to be consistent, 'gas' should turn into 'gas phase'. |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.05.04-TT-WIGOSMD notes: |
|
Yes, that is correct.
…___________________
Dr. Jörg Klausen
Federal Department of Home Affairs FDHA
Federal Office of Meteorology and Climatology MeteoSwiss
Operation Center 1 | P.O. Box 257 | CH-8058 Zurich-Airport
Phone: +41 58 460 92 23
***@***.******@***.***> | Mobile: +41 79 702 94 67 | https://orcid.org/0000-0003-2915-6028
All about weather and climate, please visit our website
www.meteoswiss.ch<https://www.meteoswiss.admin.ch/> and MeteoSwiss App<http://www.meteoswiss.admin.ch/home/services-and-publications/beratung-und-service/meteoswiss-app.html>
All about OSCAR/Surface at https://oscar.wmo.int/surface
All about GAWSIS at https://gawsis.meteoswiss.ch<https://gawsis.meteoswiss.ch/>
From: Anna Milan ***@***.***>
Sent: Wednesday, 24 May, 2023 10:54
To: wmo-im/wmds ***@***.***>
Cc: Klausen Jörg ***@***.***>; Comment ***@***.***>
Subject: Re: [wmo-im/wmds] Reintroduce paths (Issue #472)
1. In table 1-01-01, is "N species" the same as "Nitrogen species"?
—
Reply to this email directly, view it on GitHub<#472 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIFWXY4BMMUN6NAU2CKEFYLXHXEEDANCNFSM6AAAAAAWNB6ETQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
@joergklausen @fstuerzl Can you please review the path changes in this diff?
|
https://github.com/wmo-im/tt-wigosmd/wiki/2023.06.01-TT-WIGOSMD/ notes: |
Apologies for joining the discussion late. Overall the paths look OK but I've found one possible inconsistency:
I suggest adding Hydrological after Terrestrial for all hydrological variables.
I suggest maybe moving Groundwater before Aquifer or removing Groundwater
Hydrological\Liquid phase could be redundant, maybe we should eliminate Liquid phase |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.06.15-TT-WIGOSMD notes: |
https://github.com/wmo-im/tt-wigosmd/wiki/2023.06.30-TT-WIGOSMD notes: Anna mentioned that this does not need to be ready for FT2023-2 amendment document and will ask Joerg to review when ready for feedback; |
Paths are complete and integrated into the master branch. |
Details
The problem is that OSCAR/Surface is still using the paths to organize the filtering of codes and in some cases they are unable to map the tags to the paths and cannot introduce the new codes to the application. I think we can address this by adding a column for tags specifically and continue encoding of paths in the CSV tables. This will allow us to continue developing the tag approach, but it also continues the paradigm of having the same code twice for different paths.
Requestor
Anna Milan (WMO), @amilan17
@fstuerzl @luciacap
The text was updated successfully, but these errors were encountered: