Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Gedmo #57

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove Gedmo #57

merged 1 commit into from
Jul 4, 2023

Conversation

Abban
Copy link
Member

@Abban Abban commented Jun 30, 2023

  • Remove the Gedmo Doctrine Extensions and update configuration.
  • Make Subscriptions add a created date in their constructor.
  • Add PhpStan doctrine issue to baseline.
  • Update PhpUnit configuration.

@Abban Abban force-pushed the remove-gedmo branch 3 times, most recently from 453f132 to 6ed65c0 Compare June 30, 2023 11:42
@Abban
Remove Gedmo
2973495 
* Remove the Gedmo Doctrine Extensions and update configuration.
* Make Subscriptions add a created date in their constructor.
* Update PhpUnit configuration.
@Abban
Copy link
Member Author

Abban commented Jun 30, 2023

The Stan error here is fun. If I remove the baseline it throws the error saved there, but when I generate the baseline it says the same error doesn't exist. Make up your mind, Stan!

@gbirke
Copy link
Member

gbirke commented Jun 30, 2023

Is this happening locally or are the Stan versions in the dev dependencies and the container out of sync? might need https://gitlab.com/fun-tech/fundraising-frontend-docker/-/merge_requests/19

@gbirke gbirke marked this pull request as ready for review July 4, 2023 08:07
@gbirke gbirke merged commit 1890a36 into main Jul 4, 2023
0 of 2 checks passed
@gbirke gbirke deleted the remove-gedmo branch July 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbirke gbirke Awaiting requested review from gbirke

@moiikana moiikana Awaiting requested review from moiikana

@Sperling-0 Sperling-0 Awaiting requested review from Sperling-0

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abban @gbirke