Skip to content

Fix gamma correction for color not enabled on fresh install #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix gamma correction for color not enabled on fresh install #5225

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81e35ec
Initial plan
Copilot Dec 23, 2025
cba0e4f
Fix gamma correction not enabled on fresh install
Copilot Dec 23, 2025
101eef5
Complete fix for gamma correction initialization
Copilot Dec 23, 2025
b68a9e0
Address PR feedback: use gammaCorrectVal and remove CodeQL file
Copilot Dec 23, 2025
48fab36
Revert changes to .gitignore
Copilot Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions _codeql_detected_source_root
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.
Copy link
Collaborator

@DedeHai DedeHai Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

Copy link
Contributor Author

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed and added to .gitignore to prevent it from being committed again. Fixed in b68a9e0.

4 changes: 2 additions & 2 deletions wled00/cfg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,8 @@ bool deserializeConfig(JsonObject doc, bool fromFS) {
CJSON(strip.autoSegments, light[F("aseg")]);

CJSON(gammaCorrectVal, light["gc"]["val"]); // default 2.2
float light_gc_bri = light["gc"]["bri"];
float light_gc_col = light["gc"]["col"];
float light_gc_bri = light["gc"]["bri"] | 1.0f; // default to 1.0 (false)
float light_gc_col = light["gc"]["col"] | 2.2f; // default to 2.2 (true)
Copy link
Collaborator

@DedeHai DedeHai Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not initialize to gammaCorrectVal?

Copy link
Contributor Author

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Changed to use gammaCorrectVal instead of hardcoded 2.2f for better maintainability. Fixed in b68a9e0.

if (light_gc_bri > 1.0f) gammaCorrectBri = true;
else gammaCorrectBri = false;
if (light_gc_col > 1.0f) gammaCorrectCol = true;
Expand Down