-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Bumping ESPAsyncWebServer.git version to 2.4.2 to fix failing build #5173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping ESPAsyncWebServer.git version to 2.4.2 to fix failing build #5173
Conversation
WalkthroughChanged the ESPAsyncWebServer dependency specification in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related issues
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Use #v2.2.1 tag instead of @2.2.1 |
netmindz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ syntax is incompatible with git URLs
- Update ESPAsyncWebServer version pinning config to use git tag syntax (#v2.2.1)
181552c to
b2572cd
Compare
|
Never force push! |
I found it to be more specific than that - Will defer back to maintainers as to potential next steps. Questions about the contribution processFrom a process standpoint - and because I'm genuinely curious (and a huge fan of WLED in general) - hypothetically what would be the process to merge this change back into v0.14.x? Would it be a full semantic versioning patch bump to 0.14.5? To (hypothetically) implement this, I imagine making a branch from that tag, applying this PR as a cherry-picked commit, then updating the Is there a different way that does not involve creating new branches? I ask because I don't see version related branches and thus became curious. Thank you! |
Hah good call - regrettable in hindsight sorry about that |
|
There is no way "to merge this back". And downgrading AWS is out of the question. |
Sounds good, thank you. It builds successfully with v2.4.2 I'm just not sure what side effects this introduces. Hopefully this PR can serve as documentation in case anyone else is interested in compiling 0.14.x locally. The "WLED Online compiler" doesn't seem to have any problems with building this version. |
|
I have created a new tag based off 0.14.4 that includes the fix |
|
Awesome, thank you. |
Addresses the issue reported in #5171 ; this is based on the
v0.14.4tag which does not have a corresponding branch, so this PR would need to be cherry-picked by the upstream maintainers I think, or similar.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.