Skip to content

Conversation

@booherbg
Copy link

@booherbg booherbg commented Dec 9, 2025

Addresses the issue reported in #5171 ; this is based on the v0.14.4 tag which does not have a corresponding branch, so this PR would need to be cherry-picked by the upstream maintainers I think, or similar.

Summary by CodeRabbit

  • Chores
    • Updated how the ESPAsyncWebServer dependency is referenced in build configuration; the resolved version remains 2.2.1. No changes to runtime behavior, API, error handling, or other dependencies.
    • No end-user visible functional changes; builds/configuration bookkeeping only.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Walkthrough

Changed the ESPAsyncWebServer dependency specification in platformio.ini from a Git URL using an "@2.2.1" reference to the same Git URL using a "#v2.2.1" tag reference; no other files or code were modified.

Changes

Cohort / File(s) Summary
PlatformIO config
platformio.ini
Replaced ESPAsyncWebServer lib_dep Git reference form @2.2.1 with tag form #v2.2.1 (same resolved version, specification style changed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line spec change in one configuration file; no logic or API changes.

Possibly related issues

Suggested reviewers

  • netmindz

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims version 2.4.2, but the actual change only updates to version 2.2.1 with a syntax change. The title is misleading about the actual version being bumped. Update the title to accurately reflect the change, e.g., 'Update ESPAsyncWebServer dependency reference syntax to tag format' or 'Change ESPAsyncWebServer version reference from @2.2.1 to #v2.2.1'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 181552c and b2572cd.

📒 Files selected for processing (1)
  • platformio.ini (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • platformio.ini

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@blazoncek
Copy link
Contributor

Use #v2.2.1 tag instead of @2.2.1

Copy link
Member

@netmindz netmindz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ syntax is incompatible with git URLs

 - Update ESPAsyncWebServer version pinning config to use git tag syntax (#v2.2.1)
@booherbg booherbg force-pushed the v0.14.4-ESPAsyncWebServer-version-bump branch from 181552c to b2572cd Compare December 10, 2025 05:25
@blazoncek
Copy link
Contributor

Never force push!

@booherbg
Copy link
Author

@ syntax is incompatible with git URLs

I found it to be more specific than that - @ 2.4.2 actually worked where @ 2.2.1 must have stopped working at some point. My guess is that something changed relating to how the dep is registered with PlatformIO (v2.4.2 vs v2.2.1)? Either way - config is now dropped back to #2.2.1 using proper git tag syntax; the commit attached to this PR is updated

Will defer back to maintainers as to potential next steps.

Questions about the contribution process

From a process standpoint - and because I'm genuinely curious (and a huge fan of WLED in general) - hypothetically what would be the process to merge this change back into v0.14.x? Would it be a full semantic versioning patch bump to 0.14.5?

To (hypothetically) implement this, I imagine making a branch from that tag, applying this PR as a cherry-picked commit, then updating the v0.14.4 or v0.14.5 tag to point to the new branch would be one way to go.

Is there a different way that does not involve creating new branches? I ask because I don't see version related branches and thus became curious. Thank you!

@booherbg
Copy link
Author

booherbg commented Dec 10, 2025

Never force push!

Hah good call - regrettable in hindsight sorry about that

@blazoncek
Copy link
Contributor

There is no way "to merge this back". And downgrading AWS is out of the question.
If you use 0.14 from the last known commit (or tag) just update local copy. It will not change.

@booherbg
Copy link
Author

There is no way "to merge this back". And downgrading AWS is out of the question. If you use 0.14 from the last known commit (or tag) just update local copy. It will not change.

Sounds good, thank you. It builds successfully with v2.4.2 I'm just not sure what side effects this introduces. Hopefully this PR can serve as documentation in case anyone else is interested in compiling 0.14.x locally. The "WLED Online compiler" doesn't seem to have any problems with building this version.

@netmindz
Copy link
Member

I have created a new tag based off 0.14.4 that includes the fix

@netmindz netmindz closed this Dec 19, 2025
@booherbg
Copy link
Author

Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants