Skip to content

Add must-revalidate to Cache-Control header and use WEB_BUILD_TIME for ETag to fix stale UI after firmware updates #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmmiles merged 8 commits into from
Nov 28, 2025
Merged

Add must-revalidate to Cache-Control header and use WEB_BUILD_TIME for ETag to fix stale UI after firmware updates #5120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9fcdfd9
Initial plan
Copilot Nov 27, 2025
c9ac77a
Add must-revalidate to Cache-Control header for better cache invalida…
Copilot Nov 27, 2025
2dfe09e
Add must-revalidate to Cache-Control header for better cache invalida…
Copilot Nov 27, 2025
441bd62
Remove CodeQL artifact and add to gitignore
Copilot Nov 27, 2025
54f650a
Add WEB_BUILD_TIME to html_ui.h and use it for ETag generation
Copilot Nov 27, 2025
0adfc17
Change WEB_BUILD_TIME format to YYMMDD_hhmmss (UTC)
Copilot Nov 27, 2025
714a7f8
Change WEB_BUILD_TIME to UNIX timestamp integer for flash savings
Copilot Nov 27, 2025
db71cf3
Remove unnecessary must-revalidate and _codeql gitignore entry
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/cdata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,21 @@ const wledBanner = `
\t\t\x1b[36m build script for web UI
\x1b[0m`;

// Generate build timestamp as UNIX timestamp (seconds since epoch)
function generateBuildTime() {
return Math.floor(Date.now() / 1000);
}

const singleHeader = `/*
* Binary array for the Web UI.
* gzip is used for smaller size and improved speeds.
*
* Please see https://kno.wled.ge/advanced/custom-features/#changing-web-ui
* to find out how to easily modify the web UI source!
*/

// Automatically generated build time for cache busting (UNIX timestamp)
#define WEB_BUILD_TIME ${generateBuildTime()}

`;

Expand Down
2 changes: 1 addition & 1 deletion wled00/wled_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static bool inLocalSubnet(const IPAddress &client) {
*/

static void generateEtag(char *etag, uint16_t eTagSuffix) {
sprintf_P(etag, PSTR("%7d-%02x-%04x"), VERSION, cacheInvalidate, eTagSuffix);
sprintf_P(etag, PSTR("%u-%02x-%04x"), WEB_BUILD_TIME, cacheInvalidate, eTagSuffix);
}

static void setStaticContentCacheHeaders(AsyncWebServerResponse *response, int code, uint16_t eTagSuffix = 0) {
Expand Down