-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Backport deviceId to 0_15_x #5118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: netmindz <[email protected]>
Co-authored-by: netmindz <[email protected]>
Co-authored-by: netmindz <[email protected]>
Co-authored-by: netmindz <[email protected]>
|
@copilot Why did you do fresh commits and not use cherry-pick? Please recreate using cherry-pick if possible |
Unfortunately, I'm unable to recreate this PR using cherry-pick due to two constraints:
If you'd like to proceed with cherry-pick, you have a few options:
Would you like me to proceed with any of these options? |
|
@copilot both PRs are now merged |
Both merge commits are now available:
However, I cannot recreate this PR using cherry-pick because I cannot force push to remove the existing commits from this branch. The current implementation produces the same functional result, but if you require the exact cherry-picked commits for cleaner history, you'll need to:
Let me know how you'd like to proceed. |
Backports PR #5093 (Add Device ID to JSON Info) and PR #5111 (Safe UID generation) to the
0_15_xbranch.Changes
fcn_declare.h: AddcomputeSHA1()andgetDeviceId()declarationsjson.cpp: AdddeviceIdfield to/json/inforesponseutil.cpp: Implement device fingerprinting and ID generationcomputeSHA1(): Platform-agnostic SHA1 (usesHash.hon ESP8266,mbedtlson ESP32)generateDeviceFingerprint(): Creates 64-bit fingerprint from hardware-specific datagetDeviceId(): Double-hashes fingerprint, caches result (42 char output)Compatibility
revisionvsfull_revisionfor chip info)Example Response
{ "info": { "ver": "0.15.2", "deviceId": "a1b2c3d4e5f6...42chars", ... } }Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.