Fix operation of length 1 strips, such as PWM LEDs

[willmmiles]

Revert e5ba97b because it disables all length 1 segments, commonly used for PWM outputs. Segments of length 1 are valid and expected under many conditions.

This fixes the output issues reported by @naster_mick on Discord and @qistoph in #4782.

Summary by CodeRabbit

• Bug Fixes
  • Fixed blending behavior for single-pixel segments, ensuring they are included in standard blending instead of being skipped.
  • Ensures 1x1 segments use fade-based blending for consistent visual transitions.
  • Improves visual consistency and smoother fades across all segment sizes.
• Chores
  • No changes to public APIs.

[coderabbitai]

Walkthrough

Updated WS2812FX::blendSegment in wled00/FX_fcn.cpp to remove an early return for single-pixel segments, allowing them to follow the standard blending path. A later guard still enforces BLEND_STYLE_FADE when width*height == 1. No public API changes.

Changes

Cohort / File(s)	Summary
Blending logic update wled00/FX_fcn.cpp	Removed early return for length == 1 in WS2812FX::blendSegment. Single-pixel segments now use the standard blending logic; existing guard forces fade when width\*height == 1. No public/exported API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• DedeHai

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1fb9eb7 and 5fa901c.

📒 Files selected for processing (1)

• wled00/FX_fcn.cpp (0 hunks)

💤 Files with no reviewable changes (1)

• wled00/FX_fcn.cpp

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: wled_build / Build Environments (usermods)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netmindz]

If we just revert, will we not then see a crash back during blend?

[DedeHai]

yes, but that needs a different fix.

[netmindz]

Sorry about this, my bad. I'll look at the proper fix of the panic issue