Fix GitHub workflow secret access from forked PRs #4856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.github/workflows/pr-merge.yamlworkflow was failing to accesssecrets.DISCORD_WEBHOOK_BETA_TESTERSwhen triggered by pull requests from forked repositories. This is due to GitHub's security restriction that preventspull_requestevents from forks accessing repository secrets.Changes Made
1. Changed trigger from
pull_requesttopull_request_targetsecrets.DISCORD_WEBHOOK_BETA_TESTERSto be accessible for Discord notifications2. Added proper merge condition
if: github.event.pull_request.merged == trueat the job level3. Removed unnecessary checkout step
4. Maintained security measures
Security Considerations
Using
pull_request_targetis safe in this context because:The workflow will now successfully notify Discord when PRs from forked repositories are merged while maintaining proper security controls.
Fixes #4855.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.