Bugfix for brightness factor upon save: fixes #4824

[DedeHai]

Summary by CodeRabbit

• New Features

  • Added support for parallel I2S output on ESP32 platforms, including UI options and configuration handling.
  • Enhanced segment geometry and mapping options, with improved 2D and mapping support.
  • Added new environment and platform configuration options for ESP32 V4 and esp32_pico-D4.
  • Improved accessibility with new tooltips and UI element IDs in the web interface.

• Improvements

  • Refined color handling to consistently use a dedicated primary color variable for all interfaces and integrations.
  • Expanded and standardized hardware limits and configuration for ESP32-S2 and other ESP32 variants.
  • Enhanced LED bus management, including memory usage estimation and platform-specific optimizations.
  • Improved segment and effect timing for smoother animations and more precise frame control.
  • Updated documentation and changelog with recent releases and requirements.

• Bug Fixes

  • Fixed issues with temperature unit display in BME280 usermod and WiFi reconnect logic.
  • Corrected array handling and loop logic in several effects and 2D modes.
  • Addressed potential glitches when accessing the filesystem during LED updates.

• Refactor

  • Modernized internal bus and segment management for better performance and maintainability.
  • Replaced fixed arrays with dynamic vectors for bus configuration.

• Chores

  • Updated version numbers and build scripts.
  • Improved debug output and error handling for easier troubleshooting.

[coderabbitai]

Caution

Review failed

Failed to post review comments.

Walkthrough

This update introduces significant refactoring and feature enhancements across the WLED codebase. Major changes include unified and expanded support for ESP32 variants (notably ESP32-S2/S3), a switch from the global color array col to colPri for primary color handling, extensive modernization and memory management improvements in LED bus and effect/segment management, and the addition of parallel I2S output configuration for advanced LED setups. The update also brings UI/UX improvements, new configuration options, and numerous bug fixes and optimizations throughout the project.

Changes

Cohort / File(s)	Change Summary
Bus Management & Hardware Abstraction wled00/bus_manager.cpp, wled00/bus_manager.h, wled00/bus_wrapper.h, wled00/pin_manager.cpp, wled00/const.h	Refactored bus management to use vectors instead of fixed arrays, unified and expanded ESP32 variant support, improved memory usage calculation, added parallel I2S support, and modernized type usage. Pin availability checks now differentiate ESP32 variants. Hardware constants updated for new platforms.
FX & Segment Refactoring wled00/FX.cpp, wled00/FX.h, wled00/FX_fcn.cpp, wled00/json.cpp, wled00/led.cpp, wled00/wled.cpp, wled00/presets.cpp, wled00/xml.cpp	Major refactor of effect functions, segment geometry, and palette handling. Introduced new segment methods, improved timing logic, segment buffer management, and memory allocation. Enhanced JSON state/segment deserialization and XML output.
Color Handling Migration wled00/led.cpp, wled00/button.cpp, wled00/hue.cpp, wled00/mqtt.cpp, wled00/xml.cpp, usermods/usermod_rotary_brightness_color/usermod_rotary_brightness_color.h, usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h, wled00/wled.h	Replaced all uses of the col array with colPri for primary color storage and manipulation across the codebase and usermods, ensuring consistent color handling.
Parallel I2S Output Support wled00/data/settings_leds.htm, wled00/data/settings_sec.htm, wled00/data/common.js, wled00/data/index.htm, wled00/data/index.js, wled00/xml.cpp, wled00/set.cpp, wled00/cfg.cpp, wled00/wled.h	Added UI and backend support for configuring parallel I2S output, including new checkboxes, serialization/deserialization, and platform-specific logic for advanced LED setups.
PlatformIO & Build System platformio.ini, platformio_override.sample.ini, pio-scripts/build_ui.py, .github/workflows/release.yml, .gitignore, package.json	Added new ESP32 build environments, updated library versions, standardized build flags, improved UI build script with Node.js checks, enhanced release workflow with changelog generation, and updated ignored files.
Usermod & Miscellaneous Fixes usermods/BME280_v2/usermod_bme280.h, usermods/audioreactive/audio_reactive.h, usermods/rgb-rotary-encoder/readme.md	Fixed temperature unit handling, improved peak reset timing, and updated library requirements/documentation for usermods.
Remote & ESPNOW Handling wled00/remote.cpp, wled00/fcn_declare.h, wled00/udp.cpp	Refactored ESP-NOW remote handling to defer processing outside the callback, added timeout for safe filesystem access, and updated function signatures.
Configuration & Utilities wled00/cfg.cpp, wled00/util.cpp, wled00/fcn_declare.h	Simplified bus config deserialization, improved error handling, enhanced value parsing for complex input forms, and updated function declarations.
UI/UX & Accessibility Improvements wled00/data/index.js, wled00/data/settings_leds.htm, wled00/data/common.js, wled00/data/index.htm	Improved tooltips, accessibility, and palette management UI. Added new warning displays and utility functions for platform detection.
Documentation & Changelog CHANGELOG.md	Added new entries for recent builds and documented key fixes and features.
Network & Miscellaneous wled00/network.cpp	Added debug output for unhandled WiFi events.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~90+ minutes

Complexity: This PR is extensive, with high-impact changes across core subsystems (FX, bus management, segment logic, configuration, UI, and color handling), platform-specific enhancements, and significant refactoring. It requires careful review for regressions, compatibility, and correctness.

Possibly related PRs

• Multifix #4568: Also migrates usermod code from col to colPri, directly overlapping with this PR's color handling changes.
• Update crude parallel I2S detection #4713: Updates parallel I2S detection logic in the LED settings UI, directly related to this PR's addition of parallel I2S configuration and UI logic.
• Bugfixes in FX data allocation #4783: Addresses FX data buffer allocation and resizing in segment management, overlapping with this PR's FX and segment buffer refactoring.

Suggested reviewers

• willmmiles
• blazoncek

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netmindz]

@coderabbitai your generated summary is completely wrong. It does not relate to the commit

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the actual changes in this PR
gh pr view 4827 --repo wled/WLED --json commits,files

# Get the diff for this specific PR to understand what was actually changed
gh pr diff 4827 --repo wled/WLED | head -200

Length of output: 1170

---

@netmindz You're absolutely right, and I apologize for the confusion. The summaries I provided are completely unrelated to this PR.

This PR (#4827) contains a single, focused change in wled00/wled.cpp:

• Moves the BusManager::setBrightness() call to after segment alignment/fixing
• Changes the brightness value from bri to scaledBri(bri) to properly apply the brightness scaling factor

This one-line fix ensures that the brightness factor is correctly applied when buses are re-initialized during save operations, addressing issue #4824.

The extensive summaries about release workflows, bus management refactoring, and other changes appear to be from a different context entirely. Thank you for pointing this out!