Skip to content

Add TwinkleFadeIn effect #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DedeHai merged 7 commits into from
Sep 20, 2025
Merged

Add TwinkleFadeIn effect #4728

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
54efb72
Add TwinkleFadeIn effect (#3738)
benjamw Jun 12, 2025
5742dd7
convert to checkbox
benjamw Jun 19, 2025
d6e95ad
add checkbox label
benjamw Jun 19, 2025
95fb838
fix logic issue
benjamw Jun 19, 2025
761cd67
make language more intuitive
benjamw Jun 19, 2025
eb77df9
fix progmem string
benjamw Jun 20, 2025
e468fb8
Merge branch 'wled:main' into main
benjamw Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions wled00/FX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2555,9 +2555,11 @@ static CRGB twinklefox_one_twinkle(uint32_t ms, uint8_t salt, bool cat)
// This is like 'triwave8', which produces a
// symmetrical up-and-down triangle sawtooth waveform, except that this
// function produces a triangle wave with a faster attack and a slower decay
if (cat) //twinklecat, variant where the leds instantly turn on
{
if (cat) { //twinklecat, variant where the leds instantly turn on and fade off
bright = 255 - ph;
if (SEGMENT.check2) { //reverse checkbox, reverses the leds to fade on and instantly turn off
bright = ph;
}
} else { //vanilla twinklefox
if (ph < 86) {
bright = ph * 3;
Expand Down Expand Up @@ -2665,7 +2667,7 @@ uint16_t mode_twinklecat()
{
return twinklefox_base(true);
}
static const char _data_FX_MODE_TWINKLECAT[] PROGMEM = "Twinklecat@!,Twinkle rate,,,,Cool;!,!;!";
static const char _data_FX_MODE_TWINKLECAT[] PROGMEM = "Twinklecat@!,Twinkle rate,,,,Cool;!,!;!,Reverse";

@DedeHai DedeHai Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check2 is after cooling checkbox:
"Twinklecat@!,Twinkle rate,,,,Cool,Reverse;!,!;!";

please make sure to test your code so it does what you want it to.

@benjamw benjamw Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan on testing it. Thanks for the updates.



uint16_t mode_halloween_eyes()
Expand Down
1 change: 1 addition & 0 deletions wled00/FX.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ extern byte realtimeMode; // used in getMappedPixelIndex()
#define FX_MODE_PS1DSONICBOOM 215
#define FX_MODE_PS1DSPRINGY 216
#define FX_MODE_PARTICLEGALAXY 217

@DedeHai DedeHai Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

#define MODE_COUNT 218


Expand Down