Skip to content

fix for AJ-SR04M sensor #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexxnsk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix for AJ-SR04M sensor #4637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c1a6d6
fix for AJ-SR04M sensor
lexxnsk Apr 9, 2025
55c69d0
fix: restore mistakenly deleted line
lexxnsk Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions usermods/Animated_Staircase/Animated_Staircase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ class Animated_Staircase : public Usermod {
digitalWrite(signalPin, HIGH);
delayMicroseconds(10);
digitalWrite(signalPin, LOW);
Copy link
Collaborator

@blazoncek blazoncek Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is required to drop signal pin LOW and end transmission. Please revert.

Copy link
Author

@lexxnsk lexxnsk Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right.
It was mistakenly deleted

Copy link
Author

@lexxnsk lexxnsk Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted this line and committed this fix as well. Please, have a look.

return pulseIn(echoPin, HIGH, maxTimeUs) > 0;
unsigned long duration = pulseIn(echoPin, HIGH, 30000);
return (duration > 0 && duration < maxTimeUs);
}

bool checkSensors() {
Expand Down Expand Up @@ -564,4 +565,4 @@ const char Animated_Staircase::_togglePower[] PROGMEM = "toggle-on


static Animated_Staircase animated_staircase;
REGISTER_USERMOD(animated_staircase);
REGISTER_USERMOD(animated_staircase);