-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Get TTGO-T-Display usermod to build #4600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
details, and force an older version of dependent library TFT_eSPI.
Revised WLED_RELEASE_NAME to "WLED_T-Display"
Update platformio_override.ini
Removed Serial.begin statement from userSetup
This allows a v1 usermod to be linked as a library, too. Of course, only one such usermod can be included, or a linker error will result.
Avoids any collisions with other source files.
Convert to a library-based usermod, allowing easy inclusion with the custom_usermods feature. The BTNPIN override and display model selection are handled via a build python script, so it is no longer necessary modify the TFT_eSPI library install.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. |
|
Somewhat ironically, I was just poking this branch last night, as the S3 test board I picked up happens to have a TFT display. I'll push an update shortly with some additional build-time script code for using different display modules. |
|
We should migrate to V2 |
Allow specifying the display setup file as an environment parameter. Files are looked for anywhere in the include path of WLED itself, and the direct dependencies of the TTGO-T-Display module (ie. TFT_eSPI).
Adds better support for newer CPUs.
Check if the path is fully qualified before searching; this allows using files outside of the WLED folder.
|
Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. |
Adopt spiff72's upstream changes, and update the TTGO-T-Display usermod to the new library framework. This allows it to be included in
custom_usermodslike any other usermod. All other build requirements are handled by a library script, so the TFT_eSPI library does not need to be hand modified.Fixes #4375.
NOTE: I do not actually have this hardware, so this is untested beyond "it builds"; I've double checked that the correct build flags are handed to each source, but that's about as far as I can go. Can someone with one of these boards please give it a try?