Skip to content

Conversation

@willmmiles
Copy link
Member

Adopt spiff72's upstream changes, and update the TTGO-T-Display usermod to the new library framework. This allows it to be included in custom_usermods like any other usermod. All other build requirements are handled by a library script, so the TFT_eSPI library does not need to be hand modified.

Fixes #4375.

NOTE: I do not actually have this hardware, so this is untested beyond "it builds"; I've double checked that the correct build flags are handed to each source, but that's about as far as I can go. Can someone with one of these boards please give it a try?

spiff72 and others added 12 commits December 24, 2024 00:19
details, and force an older version of dependent library TFT_eSPI.
Revised WLED_RELEASE_NAME to "WLED_T-Display"
Update platformio_override.ini
Removed Serial.begin statement from userSetup
This allows a v1 usermod to be linked as a library, too.  Of course,
only one such usermod can be included, or a linker error will result.
Avoids any collisions with other source files.
Convert to a library-based usermod, allowing easy inclusion with the
custom_usermods feature.  The BTNPIN override and display model
selection are handled via a build python script, so it is no longer
necessary modify the TFT_eSPI library install.
@willmmiles willmmiles self-assigned this Mar 18, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for contributing to WLED! ❤️

@github-actions github-actions bot added the stale This issue will be closed soon because of prolonged inactivity label Jul 16, 2025
@willmmiles
Copy link
Member Author

Somewhat ironically, I was just poking this branch last night, as the S3 test board I picked up happens to have a TFT display. I'll push an update shortly with some additional build-time script code for using different display modules.

@github-actions github-actions bot removed the stale This issue will be closed soon because of prolonged inactivity label Jul 17, 2025
@willmmiles willmmiles mentioned this pull request Aug 13, 2025
@netmindz
Copy link
Member

We should migrate to V2

Allow specifying the display setup file as an environment parameter.
Files are looked for anywhere in the include path of WLED itself, and
the direct dependencies of the TTGO-T-Display module (ie. TFT_eSPI).
Adds better support for newer CPUs.
Check if the path is fully qualified before searching; this allows using
files outside of the WLED folder.
@github-actions
Copy link

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs.
Thank you for contributing to WLED! ❤️

@github-actions github-actions bot added the stale This issue will be closed soon because of prolonged inactivity label Dec 13, 2025
@github-actions github-actions bot closed this Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue will be closed soon because of prolonged inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usermods TTGO-T-Display does not compile

3 participants