-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Usermod: Analog clock #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usermod: Analog clock #2736
Conversation
|
Hi and thanks for that mod, i connected my clock to a 2nd GPIO and declared it as segment2. But this doesn't seems to work since the settings in your usermod will not be safed.... anyway: Is it possible to change the usermod settings (colors) with the api / mqtt ? |
|
Following |
The mod doesn't honor segments (yet), just offsets. What is your LED configuration and what are the bounds you entered in the mod's settings? It doesn't save the boundaries when they're "invalid".
Not yet, but certainly a good idea :-) |
03133ee to
1c60170
Compare
|
@Aircoookie can you re-target this to main now and reopen? |
|
Shoot, I figured it would rebase outstanding PRs instead of closing them. Rebasing actually requires restoring 0_14 branch, not a good UX given the rest of GitHub works perfectly well. At least it shouldn't tell me that the branch can be "safely deleted" if that action closes PRs without warning 😅 |
|
Sorry, I was under the impression (since @blazoncek asked for it in another PR of me) I'd have to rebase this to 0_14 as well. By the way, using this on 0_14 with my clock fixed an occasional flickering of random LEDs. Can't wait for 0.14 to be released :-) |
|
No, rebasing it to 0_14 was correct on your part, the error is on me for merging 0_14 to main before merging your PR :D |
|
I like to try this usermod but cannot compile In file included from wled00\usermods_list.cpp:153:0: |
I have moved the analog clock overlay functionality to a user mod and added following features:
If desired, I could also remove the now obsolete "analog clock overlay" from the base code.