feat: let rollup configure min base fee by wlawt · Pull Request #10 · wlawt/optimism

wlawt · 2025-07-21T16:13:27Z

WIP

This PR lets the rollup configure the minimum base fee log2

TODO:

How to re-generate the op-e2e/bindings?
Finish the logic to pass in the configurable from SystemConfig into the EIP1559Params
More testing everywhere? (to also confirm if above ^ was done correctly)
Take the log2

op-program/client/l2/engineapi/block_processor.go

op-deployer/pkg/deployer/opcm/opchain.go

op-e2e/opgeth/op_geth.go

op-node/rollup/attributes/engine_consolidate.go

op-node/rollup/attributes/engine_consolidate_test.go

op-node/rollup/derive/attributes.go

op-program/client/l2/engineapi/block_processor.go

op-service/eth/types.go

packages/contracts-bedrock/src/L2/L1Block.sol

packages/contracts-bedrock/interfaces/L1/ISystemConfig.sol

op-service/eth/types.go

packages/contracts-bedrock/interfaces/L1/ISystemConfig.sol

wlawt · 2025-07-25T16:04:51Z

op-node/rollup/interop/indexing/attributes.go

+		denominator, elasticity uint64
+		minBaseFeeLog2          uint8
+	)
+	if len(extraData) == 10 {


not sure if there was a way to do rollup.IsJovian

oof. This code makes it clearer why DecodeHoloceneExtraData behaves the way it does with return values of 0, 0 when the extra data doesn't fit the Holocene format. In this context, maybe we've implemented DecodeMinBaseFeeExtraData incorrectly. I think we should update it to check if len(extra) == 9 and call the earlier DecodeHoloceneExtraData function to get the denominator and elasticity, and add zero as the third return value for minimum base fee. We'd also want to update the doc comment to indicate that it makes a best effort to decode the extra data for every block in the chain's history, including before the minimum base fee was implemented.

With those changes, we can remove the length check here and just call DecodeMinBaseFeeExtraData.

op-service/eth/types.go

packages/contracts-bedrock/src/L1/SystemConfig.sol

op-node/rollup/attributes/engine_consolidate.go

op-service/eth/types.go

op-node/rollup/attributes/engine_consolidate.go

wlawt · 2025-07-28T14:47:05Z

op-node/rollup/interop/indexing/attributes.go

 	// So we translate it here.
 	extraData := invalidatedBlock.ExecutionPayload.ExtraData
-	denominator, elasticity := eip1559.DecodeHoloceneExtraData(extraData)
+	denominator, elasticity, minBaseFeeLog2 := eip1559.DecodeMinBaseFeeExtraData(extraData)


@niran this looks much better

niran · 2025-07-28T15:43:18Z

Let's open this RP upstream for visibility.

Co-authored-by: Matt Solomon <matt@mattsolomon.dev>

…x right-pad of uint8 in abi-encode

… minimum enabled

* use u64 * fix system/fees/minbasefee_test

…m diffs

wlawt commented Jul 21, 2025

View reviewed changes

op-program/client/l2/engineapi/block_processor.go Outdated Show resolved Hide resolved

niran suggested changes Jul 22, 2025

View reviewed changes

wlawt force-pushed the configurable-min-basefee branch from 34fe331 to 56100a8 Compare July 22, 2025 14:08

niran suggested changes Jul 24, 2025

View reviewed changes

packages/contracts-bedrock/src/L2/L1Block.sol Outdated Show resolved Hide resolved

packages/contracts-bedrock/interfaces/L1/ISystemConfig.sol Outdated Show resolved Hide resolved

op-service/eth/types.go Outdated Show resolved Hide resolved

wlawt commented Jul 24, 2025

View reviewed changes

packages/contracts-bedrock/interfaces/L1/ISystemConfig.sol Outdated Show resolved Hide resolved

wlawt force-pushed the configurable-min-basefee branch from 4a51776 to 6226558 Compare July 25, 2025 15:01

wlawt commented Jul 25, 2025

View reviewed changes

op-service/eth/types.go Outdated Show resolved Hide resolved

wlawt requested a review from niran July 25, 2025 19:47

niran suggested changes Jul 25, 2025

View reviewed changes

wlawt commented Jul 28, 2025

View reviewed changes

op-node/rollup/attributes/engine_consolidate.go Outdated Show resolved Hide resolved

wlawt commented Jul 28, 2025

View reviewed changes

wlawt mentioned this pull request Jul 28, 2025

update minimum base fee design doc ethereum-optimism/design-docs#308

Closed

wlawt mentioned this pull request Jul 28, 2025

feat: introduce configurable min basefee ethereum-optimism/optimism#16852

Closed

2 tasks

wlawt force-pushed the configurable-min-basefee branch 4 times, most recently from 6ce75e9 to 279ca8e Compare August 8, 2025 13:57

wlawt force-pushed the configurable-min-basefee branch from ed3dc9b to 7f9a1a7 Compare August 20, 2025 20:21

wlawt force-pushed the configurable-min-basefee branch 4 times, most recently from 9ea7697 to 12e4a5f Compare September 2, 2025 17:59

wlawt mentioned this pull request Sep 3, 2025

feat: introduce minimum base fee ethereum-optimism/op-geth#666

Merged

wlawt and others added 5 commits September 4, 2025 15:06

min-base-fee solidity diffs

03a16d9

Update packages/contracts-bedrock/src/L1/SystemConfig.sol

aecffb7

Co-authored-by: Matt Solomon <matt@mattsolomon.dev>

just pre-pr

2106199

Merge remote-tracking branch 'origin/develop' into cmb-solidity

7aa2197

just pre-pr

7c6a2cb

wlawt and others added 26 commits September 11, 2025 10:37

fix user_test

eb9f156

add jovian fork and activation test

ee8762c

wip - add acceptance test

0827e86

gofmt + add op-e2e for minBaseFee + emit update for SystemConfig + fi…

ea0f7e9

…x right-pad of uint8 in abi-encode

use feature flags

0b573dd

feedback on e2e and acceptance tests

6a647cb

kurtosis fix test

1ad26f1

Switch from log2 to significand + exponent for min base fee

8d1cbe2

Remove unnecessary type cast

ed28283

Rewrite tests to work with sysgo and correct the logic for testing w/…

4226742

… minimum enabled

Rename test

cfb7569

Extract testing utilities into dsl functions like the operator fee tests

743b9ad

Bump op-geth to the latest version where the tests pass

48d2b44

Use u64 approach (#12)

9d311f3

* use u64 * fix system/fees/minbasefee_test

feedback on contracts + remove diff on derive

c448ee8

fix ci

fbfb146

remove bindings and solidity diffs

4b2a48c

use ActivateForkAtOffset

0389332

restore to develop due to merge conflict errors + remove op-e2e/syste…

0666c5f

…m diffs

remove TestJovianInvalidPayload

710bfc1

jovian_action_test feedback

bbbf464

remove unused code/funcs in l2_sequencer and verifier

ec9db14

move & combine TestJovianActivationAtGenesis to actions/proofs

3ccc15f

devstack/acceptance test feedback

8d7b427

move mbf dsl into test file

4749b16

update kurtosis images

0a0052a

wlawt force-pushed the configurable-min-basefee branch from 12e4a5f to 0a0052a Compare September 11, 2025 20:38

wlawt added 3 commits September 11, 2025 16:44

reduce diffs

c26607e

merge cmb-solidity

df671ce

add acceptance-test.yaml to get kurtosis to run

be98d00

Conversation

wlawt commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wlawt Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

niran Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

wlawt Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wlawt Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

niran commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wlawt commented Jul 21, 2025 •

edited

Loading