fix: sonar scanner

wkylin · Nov 7, 2024 · 196bf03 · 196bf03
1 parent e539666
commit 196bf03
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 17 deletions.
diff --git a/.scannerwork/report-task.txt b/.scannerwork/report-task.txt
@@ -1,6 +1,6 @@
 projectKey=pro-react-admin
 serverUrl=http://localhost:9000
-serverVersion=9.9.0.65466
+serverVersion=10.7.0.96327
 dashboardUrl=http://localhost:9000/dashboard?id=pro-react-admin
-ceTaskId=AYb_3hPyWpAQAZNXFhho
-ceTaskUrl=http://localhost:9000/api/ce/task?id=AYb_3hPyWpAQAZNXFhho
+ceTaskId=22109086-7690-4db8-bfa6-ec9a25157b56
+ceTaskUrl=http://localhost:9000/api/ce/task?id=22109086-7690-4db8-bfa6-ec9a25157b56
diff --git a/src/components/container/musicPlayer/Player.jsx b/src/components/container/musicPlayer/Player.jsx
@@ -26,7 +26,9 @@ const Player = ({ activeSong, isPlaying, volume, seekTime, onEnded, onTimeUpdate
       onEnded={onEnded}
       onTimeUpdate={onTimeUpdate}
       onLoadedData={onLoadedData}
-    />
+    >
+      <track src="aaaa" kind="subtitles" srcLang="en" label="English" />
+    </audio>
   )
 }
 

diff --git a/src/components/stateless/StarRating/index.jsx b/src/components/stateless/StarRating/index.jsx
@@ -15,22 +15,22 @@ const StarRating = ({ value }) => {
 
   const hoverOver = (event) => {
     let val = 0
-    if (event && event.target && event.target.getAttribute('data-star-id'))
-      val = event.target.getAttribute('data-star-id')
+    if (event?.target?.getAttribute('data-star-id')) val = event.target.getAttribute('data-star-id')
     setSelection(val)
   }
   return (
-    <div
+    <span
       onMouseOut={() => hoverOver(null)}
       onClick={(e) => setRating(e.target.getAttribute('data-star-id') || rating)}
       onMouseOver={hoverOver}
       role="button"
+      tabIndex="0"
     >
       {Array.from({ length: 5 }, (v, i) => (
         <Star starId={i + 1} key={`star_${i + 1}`} marked={selection ? selection >= i + 1 : rating >= i + 1} />
       ))}
       <span>{rating}</span>
-    </div>
+    </span>
   )
 }
 

diff --git a/src/pages/home/index.jsx b/src/pages/home/index.jsx
@@ -158,11 +158,11 @@ const Home = () => {
 
   return (
     <FixTabPanel>
-      <h2 style={{ marginBottom: 15 }}>
+      <section style={{ marginBottom: 15 }}>
         <TypedText>Cool! Hi, React & Ant Design!</TypedText>
-      </h2>
+      </section>
 
-      <h2 className={styles.avatar}>React version: {version}</h2>
+      <section className={styles.avatar}>React version: {version}</section>
 
       <section>
         I love coding in <AlternatingText alternateText={['javascript', 'typescript', 'rect', 'vue']} />.

diff --git a/src/pages/postmessage/index.jsx b/src/pages/postmessage/index.jsx
@@ -38,7 +38,6 @@ const PostMessage = () => {
           border: 'none',
           width: '100%',
         }}
-        frameborder="0"
         src={childOrigin}
         ref={ref}
         width="800px"
@@ -47,7 +46,7 @@ const PostMessage = () => {
         loading="lazy"
         allowfullscreen
         allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
-        referrerpolicy="no-referrer-when-downgrade"
+        referrerPolicy="no-referrer-when-downgrade"
         sandbox="allow-scripts allow-same-origin"
       />
     </>

diff --git a/src/pages/print/test/toPrint.jsx b/src/pages/print/test/toPrint.jsx
@@ -1,6 +1,6 @@
 import * as React from 'react'
 
-import image from './px4T-test_image.png'
+import imagePng from './px4T-test_image.png'
 
 const ComponentToPrint = React.forwardRef((props, ref) => {
   const { text } = props
@@ -89,7 +89,7 @@ const ComponentToPrint = React.forwardRef((props, ref) => {
           <tr>
             <td>Image: Local Import</td>
             <td>
-              <img alt="A test image" src={image} width="200" />
+              <img alt="A test" src={imagePng} width="200" />
             </td>
           </tr>
           <tr>
@@ -123,8 +123,10 @@ const ComponentToPrint = React.forwardRef((props, ref) => {
           <tr>
             <td>Input: Radio</td>
             <td>
-              Blue <input type="radio" id="blue" name="color" value="blue" />
-              Red <input type="radio" id="red" name="color" value="red" />
+              <span>Blue</span>
+              <input type="radio" id="blue" name="color" value="blue" />
+              <span>Red</span>
+              <input type="radio" id="red" name="color" value="red" />
             </td>
           </tr>
           <tr>