Fix compilation error and address review comments #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
added a commit
that referenced
this pull request
May 10, 2019
Currently, this test can fail with the not-very-helpful [1,2]:
fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
<bool>: false
to be true
Since this test is the only CheckForAllJobPodsRunning consumer, and
has been since CheckForAllJobPodsRunning landed in 116eda0
(Implements an upgrade test for Job, 2017-02-22, kubernetes#41271), this commit
refactors the function to EnsureJobPodsRunning, dropping the opaque
boolean, and constructing a useful error summarizing the divergence
from the expected parallelism and the status of listed Pods.
Thanks to Maciej Szulik for the fixups [3] :).
[1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
[3]: #1
Owner
wking
added a commit
to wking/origin
that referenced
this pull request
Jun 13, 2019
…lure message
Currently, this test can fail with the not-very-helpful [1,2]:
fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
<bool>: false
to be true
Since this test is the only CheckForAllJobPodsRunning consumer, and
has been since CheckForAllJobPodsRunning landed in 116eda0
(Implements an upgrade test for Job, 2017-02-22, #41271), this commit
refactors the function to EnsureJobPodsRunning, dropping the opaque
boolean, and constructing a useful error summarizing the divergence
from the expected parallelism and the status of listed Pods.
Thanks to Maciej Szulik for the fixups [3] :).
Backports kubernetes/kubernetes@96b04bfeac
(test/e2e/upgrades/apps/job: List Pods in failure message, 2019-05-09,
kubernetes/kubernetes#77716).
[1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
[3]: wking/kubernetes#1
---
wking
added a commit
to wking/origin
that referenced
this pull request
Jun 13, 2019
…lure message
Currently, this test can fail with the not-very-helpful [1,2]:
fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
<bool>: false
to be true
Since this test is the only CheckForAllJobPodsRunning consumer, and
has been since CheckForAllJobPodsRunning landed in 116eda0
(Implements an upgrade test for Job, 2017-02-22, #41271), this commit
refactors the function to EnsureJobPodsRunning, dropping the opaque
boolean, and constructing a useful error summarizing the divergence
from the expected parallelism and the status of listed Pods.
Thanks to Maciej Szulik for the fixups [3] :).
Backports kubernetes/kubernetes@96b04bfeac
(test/e2e/upgrades/apps/job: List Pods in failure message, 2019-05-09,
kubernetes/kubernetes#77716).
[1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
[3]: wking/kubernetes#1
---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.