This repository has been archived by the owner on Jan 2, 2023. It is now read-only.
Applying the font spaces fix used in the official qt #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
This was referenced May 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this PR => https://codereview.qt-project.org/#/c/154801/
This however replaces strings with underscores which is technically changing the font name.
Therefore I propose replacing the space with an escaped space (
#20)I will create another PR for that purpose. You may decide what you like better.
Full disclosure: I did not test this solution, but I believe it works just like in the official qt repository.
This closes #37, closes wkhtmltopdf/wkhtmltopdf#3857, and closes wkhtmltopdf/wkhtmltopdf#3672