Calculate requiredHeight based on tallest cell #29
Conversation
Previously the `requiredHeight` for the row was set to the height of the first cell found in the row. If another cell happened to want to push the row height taller, the row height was not correctly calculated and it appeared the row would fit on the current page. Once we get to rendering, the row _doesn't_ fit on the current page and flips itself to the next page -- without the headHeight adjustment to the row position. The THEAD then prints itself over the top of that row. The processing time here will take longer as we now need to determine the `contentLogicalHeight` for every cell rather than just the first, but there's no way around that.
|
Will review it in detail tomorrow, but looks good otherwise. Fantastic insight and debugging to identify the root cause of the issue 👍 |
|
Can you send the files to the email address listed in my profile? |
|
+1. Would definitely like to see this go through. |
|
Unable to review in detail, would try to do it soon. |
|
@RickMeasham Good work. I think it has overlapping issue with header and footer. |
|
@viswa18 Thanks .. but I'm not sure if you're saying my solution has an issue or not. If it does, can you please post details, an example, and a way to reproduce? |
|
Nice fix @RickMeasham. I see this as an isolated fix to what everyone has been complaining about and not sure how it would introduce what @viswa18 mentioned. Seems to me like the bug that he's referring to would have to already be present, so this wouldn't be going backward. Would love to hear an explanation of what was mentioned about overlapping. But +1 to getting this merged. |
|
I haven't really tested the corner case mentioned here, but better to release a partial fix than to not do anything for so long. Thanks a lot for the contribution, and extremely sorry for the delay! This will be a part of the |
|
❤️ |
Previously the
requiredHeightfor the row was set to the height of the first cell found in the row. If another cell happened to want to push the row height taller, the row height was not correctly calculated and it appeared the row would fit on the current page. Once we get to rendering, the row doesn't fit on the current page and flips itself to the next page -- without the headHeight adjustment to the row position. The THEAD then prints itself over the top of that row.The processing time here will take longer as we now need to determine the
contentLogicalHeightfor every cell rather than just the first, but there's no way around that.