-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Side scroll request in the wheelEvent with the shift modifier in qt5 mode #1472
base: main
Are you sure you want to change the base?
Conversation
@Kokika looks like qt5 ev.angleDelta() handles it automatically. (I confirmed on my macOS + PyQt5) https://doc.qt.io/qt-5/qwheelevent.html |
@wkentaro I am testing on Ubuntu 24.04 with PyQt5 5.15.9 and here it isn't handles it automatically. |
I see, but your change breaks the other systems where qt5 automatically flips the order (because you flip again), so I can't merge. We need to understand why qt5 won't work for you. |
I realized it and I totally agree. I am searching the reason. |
@wkentaro Could you test it if the shift modifier is in mods? Or maybe it is applied and take away from the mods on Mac os? |
@Kokika I tested on my Linux machine, and reproduced your phenomenon. And on macOS, shift modifier is in mods (so your change makes it both horizontal scroll regardless of shift press). Probably we need to add if-block for platform... |
I tested this on Windows and same like Linux, so it is also need. |
I added Mac os check for side scroll. @wkentaro, could you test it please? |
This is fix for QT5.
Convient function for side scrolling on canvas with shift modifier. This idea copied other program behavior.