refactor!: remove deprecated --id CLI flag#449
Merged
Conversation
wkentaro
force-pushed
the
remove/deprecated-id-flag
branch
from
d679653 to
a7dae9b
Compare
wkentaro
changed the title
wkentaro
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--idCLI flag that was deprecated in version 4.3.1 with a warning saying "will be removed in 5.0"--idand has been the recommended path since 4.3.1Changes
--idargument definition from the argument parserif args.id:branch and kept only the auto-detection logic (URL regex match)url_or_idhelp text to remove the(with --id)referenceimport warnings