Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt gdown to be used as python library #244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Skitionek
Copy link

@Skitionek Skitionek commented Feb 20, 2023

Summary

  • Exceptions are printed only on cli (otherwise simply raised)
  • Allows for custom progress callbacks (which defaults to old behaviour)
  • stderr stands for "standard error" - progress messages should be printed to stdin

@wkentaro
Copy link
Owner

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

@wkentaro
Copy link
Owner

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

@wkentaro wkentaro added the feature for pr label Feb 21, 2023
@Skitionek
Copy link
Author

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

image

Interesting, yet putting flag --quiet should silence all progress prints from code.... Therefore it still can be used the way you mentioned.

@Skitionek
Copy link
Author

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

Moved Exceptions to separate PR: #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature for pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants