-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for iterators introduced in go1.23 #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
Suggested renaming a couple funcs, would be great to mention that in the README as well?
Ideally we'd want iterators from newest pairs too?
Thanks @wk8 I chose to match the naming of the I can also update the readme |
Actually in light of this I changes all the names and added the new methods |
okay have address the feedback plus added a utility |
@wk8 anything else you would like changed? Otherwise can we have this merged please would be great to get a few of our dependencies updated |
I've been wanting this feature for a while now. Thanks for putting the PR together. Happy to help as needed to get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! :)
Just realized this hasn't been released yet. 🫠 Any plans to release? |
This PR adds support for the new iter package in go1.23 allowing a for range loop to be used with the ordered maps improving devex