-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 new filter, aggregation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let's update the PR and explain in high level what changed in the API |
|
MXPOL
pushed a commit
that referenced
this pull request
Dec 14, 2021
* postgres with V2 * mongo v2 * move getFilterObject to common * spanner v2 * refactor * dynamo v2 * mssql v2 * change app_data_e2e test * nop * mysql V2 * airtable V2 * firestore V2
MXPOL
pushed a commit
that referenced
this pull request
Dec 15, 2021
* postgres with V2 * mongo v2 * move getFilterObject to common * spanner v2 * refactor * dynamo v2 * mssql v2 * change app_data_e2e test * nop * mysql V2 * airtable V2 * firestore V2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't change e2e yet.
Changed filter_parser to work with v2 API
The filter was :
filter changed to:
aggregation was:
aggregation changed to:
As you can see, in aggregation:
there's no aggregation object.
The fields are with $ prefix.