Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 new filter, aggregation #86

Merged
merged 12 commits into from
Dec 8, 2021
Merged

V2 new filter, aggregation #86

merged 12 commits into from
Dec 8, 2021

Conversation

Idokah
Copy link
Collaborator

@Idokah Idokah commented Dec 5, 2021

Didn't change e2e yet.
Changed filter_parser to work with v2 API

The filter was :

filter: 
{
  operator: '$eq'
  fieldName: 'field'
  value: 'val'
}

filter changed to:

filter:
{
  field:  { $eq: 'val' }
}

aggregation was:

filter: { somefilter },
aggregation: {
    processingStep: {
        _id: {
            field1: 'field',
        },
        myAvg: {
            $avg: 'somefield'
        }
    },
    postFilteringStep: {
        somefilter
    },
}

aggregation changed to:

filter: { somefilter},
processingStep: {
    _id: {
        field1: '$field',
    },
    myAvg: {
        $avg: `$somefield`
    }
},
postFilteringStep: {
    somefilter
},

As you can see, in aggregation:
there's no aggregation object.
The fields are with $ prefix.

@Idokah Idokah changed the title postgres with V2 V2 new filter, aggregation Dec 5, 2021
@noam-almog
Copy link
Collaborator

let's update the PR and explain in high level what changed in the API
filter was .... changed to ...
i can't really understand what you are trying to commit like this.

@Idokah
Copy link
Collaborator Author

Idokah commented Dec 7, 2021

let's update the PR and explain in high level what changed in the API filter was .... changed to ... i can't really understand what you are trying to commit like this.
@noam-almog done

@Idokah Idokah merged commit a852485 into master Dec 8, 2021
@Idokah Idokah deleted the V2-tests branch December 8, 2021 10:11
MXPOL pushed a commit that referenced this pull request Dec 14, 2021
* postgres with V2

* mongo v2

* move getFilterObject to common

* spanner v2

* refactor

* dynamo v2

* mssql v2

* change app_data_e2e test

* nop

* mysql V2

* airtable V2

* firestore V2
MXPOL pushed a commit that referenced this pull request Dec 15, 2021
* postgres with V2

* mongo v2

* move getFilterObject to common

* spanner v2

* refactor

* dynamo v2

* mssql v2

* change app_data_e2e test

* nop

* mysql V2

* airtable V2

* firestore V2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants