Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mongo config reader to uri only #41

Merged
merged 1 commit into from
Oct 11, 2021
Merged

change mongo config reader to uri only #41

merged 1 commit into from
Oct 11, 2021

Conversation

Idokah
Copy link
Collaborator

@Idokah Idokah commented Oct 5, 2021

No description provided.

@Idokah
Copy link
Collaborator Author

Idokah commented Oct 5, 2021

From what I have seen in all the places where there is a connection to Mongo it's with the URI, and also when you open the MongoDB the URI is produced (in atlas/azure at least)
I think it will be more convenient to ask only URI.

@MXPOL
Copy link
Collaborator

MXPOL commented Oct 5, 2021

Agree.
I have never seen a need to give both username & password to connect to MongoDB it's always a URI 🧐

@noam-almog noam-almog merged commit 5a4c35c into master Oct 11, 2021
@noam-almog noam-almog deleted the mongo-srv branch October 11, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants