Firestore implementation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-almog
reviewed
Sep 9, 2021
| // const filterParser = new FilterParser() | ||
| const dataProvider = new DataProvider(firestore) | ||
| const filterParser = new FilterParser() | ||
| const dataProvider = new DataProvider(firestore,filterParser) |
noam-almog
reviewed
Sep 9, 2021
noam-almog
reviewed
Sep 9, 2021
| const filterOperations = this.filterParser.transform(filter) | ||
| const collectionRef = this.database.collection(collectionName) | ||
|
|
||
| filterOperations.forEach( filterOp => collectionRef.where(filterOp.fieldName,filterOp.opStr,filterOp.value)) |
There was a problem hiding this comment.
and spaces after ',' (again)
noam-almog
reviewed
Sep 9, 2021
| async insert(collectionName, items) { | ||
| const batch = this.database.batch() | ||
|
|
||
| items.forEach( item => batch.set(this.database.doc(`${collectionName}/${item._id}`),item)); |
noam-almog
reviewed
Sep 9, 2021
| return (await batch.commit()).length | ||
| } | ||
|
|
||
| fixDates(value) { |
There was a problem hiding this comment.
extract those two function to another file, utils perhaps ?
noam-almog
reviewed
Sep 9, 2021
| } | ||
|
|
||
| items.forEach( item => | ||
| batch.update(this.database.doc(`${collectionName}/${item._id}`),item)); |
There was a problem hiding this comment.
space after ','
shouldn't the forEach be a map or reduce here ?
noam-almog
reviewed
Sep 9, 2021
|
|
||
| async delete(collectionName, itemIds) { | ||
| const batch = this.database.batch() | ||
| itemIds.forEach( itemId => batch.delete(this.database.doc(`${collectionName}/${itemId}`)) ) |
noam-almog
reviewed
Sep 9, 2021
noam-almog
reviewed
Sep 9, 2021
| return EMPTY_FILTER; | ||
| } | ||
|
|
||
| // return { |
noam-almog
reviewed
Sep 9, 2021
| return [] | ||
| } | ||
|
|
||
| // switch (filter.operator) { |
There was a problem hiding this comment.
what happens in case of $and/$or ?
noam-almog
reviewed
Sep 9, 2021
| return (await batch.commit()).length | ||
| } | ||
|
|
||
| asEntity(docEntity) { |
noam-almog
reviewed
Sep 9, 2021
| return value | ||
| } | ||
|
|
||
| const deleteQueryBatch = async (db, query, resolve) => { |
There was a problem hiding this comment.
this code cannot be here, it should be on the main impl firestore_data_provider.js
…est a specific engine
* first version azure-adapter-installer works now only for mysql, need to insert the enviorment variables (watch in init.js file) need to change the login method, get params method (not process.env) * add spinner * fix test error azure * nop
* fix mssql connection provider * add not connected synthetic pool * extract notConnectedPool func to mssql_utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.