fix for schema service tests #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-almog
reviewed
Jan 5, 2022
packages/test-commons/lib/gen.js
Outdated
| @@ -57,9 +57,9 @@ const randomCollections = () => randomArrayOf( randomCollectionName ) | |||
|
|
|||
| const randomFieldName = () => chance.word({ length: 5 }) | |||
|
|
|||
| const randomDbField = () => ( { name: chance.word(), type: chance.word(), subtype: chance.word(), isPrimary: chance.bool() } ) | |||
| const randomCollectionField = () => ({ field: chance.word(), type: randomWixDataType() }) | |||
There was a problem hiding this comment.
why not just change name to field, why rename all of the methods ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the column object have been changed, but the random column generator haven't, this pr fix it and generates the right column object