change validate connection func #11
Conversation
Idokah
force-pushed
the
change-validate-connection
branch
from
c284717 to
9f0adeb
Compare
| res = { valid: false, error } | ||
| } | ||
| } | ||
| return res; |
There was a problem hiding this comment.
i don't understand this change, looks like debug code to me
There was a problem hiding this comment.
you suggested me to change the validateConnection function to return an object with valid = true/false and the error instead of throwing if the connection is not valid.
There was a problem hiding this comment.
ok, so why do we need to extract all of the logic to try catch ?
There was a problem hiding this comment.
because i want to use the translateErrorCodes function, this function throws the error so i need to catch it..
I know it's ugly, you have better idea to return the error without throwing?
There was a problem hiding this comment.
so create another function like translateErrorCodes that does that without throwing
Idokah
force-pushed
the
change-validate-connection
branch
2 times, most recently
from
bad4592 to
10a21b6
Compare
Idokah
force-pushed
the
change-validate-connection
branch
from
10a21b6 to
8eeacf2
Compare
…ove the unnecessary variable.
Idokah
force-pushed
the
change-validate-connection
branch
from
8eeacf2 to
1050b89
Compare
validateConnection function returns object {valid: true/false, error} instead throw
adjust the tests.