Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated config #882

Merged
merged 2 commits into from
May 28, 2023

Conversation

Naturalclar
Copy link
Contributor

Fixes #881

Removed deprecated parameter from react-native.config.js, causing autolinking to fail from react-native/cli v8

@iovoz
Copy link

iovoz commented Jul 3, 2022

Thanks for solution

@vitorbarros
Copy link

vitorbarros commented Aug 9, 2022

Is there anyone to solve the CI issue and merge this PR? @iovoz @DanielEliraz

@stale
Copy link

stale bot commented Sep 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Sep 24, 2022
@anatooly
Copy link

This fix for this warning?

warn Package react-native-notifications contains invalid configuration: "dependency.assets" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.

@stale stale bot removed the 🏚 stale label Sep 24, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Nov 9, 2022
@Naturalclar
Copy link
Contributor Author

not stale

@stale stale bot removed the 🏚 stale label Nov 16, 2022
@gavrichards
Copy link

Would be great to see this merged! 🙏

@anisimov74
Copy link
Contributor

Dear maintainers, please merge this PR, since the change is quite simple.

@stale
Copy link

stale bot commented Feb 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Feb 2, 2023
@sakramentas
Copy link

sakramentas commented Feb 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Okay that's ridiculous now. @wix I know you guys don't care about maintaining this repo anymore, but if you also don't intend to at least review/merge new contributions (while keeping this stupid stale bot active), please do us a favor and terminate the repo (or at least put a message on README saying it's not being maintained anymore).

Thanks.

@stale stale bot removed the 🏚 stale label Feb 9, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Apr 2, 2023
@angelica-snowit
Copy link

NOT STALE

@stale stale bot removed the 🏚 stale label Apr 4, 2023
@sanchitos
Copy link

NOT STALE

@fahad86
Copy link

fahad86 commented May 24, 2023

@Naturalclar can you please add a tag to the PR [type: accepted/enhancement] so that it enforce-label check doesn't fail?

@Naturalclar
Copy link
Contributor Author

@fahad86 hi there! Unfortunately I dont have access rights to set any label to the PR. Sorry about that

@DanielEliraz DanielEliraz merged commit 968e4e5 into wix:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolinking does not work with React Native 0.69.0