Fix title height not being set on Android (#4587)

Set topBar title height property
wix · Jan 16, 2019 · 09c8c37 · 09c8c37
1 parent 83f69d4
commit 09c8c37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/android/app/src/main/java/com/reactnativenavigation/parse/TitleOptions.java b/lib/android/app/src/main/java/com/reactnativenavigation/parse/TitleOptions.java
@@ -13,6 +13,7 @@
 import com.reactnativenavigation.parse.params.Text;
 import com.reactnativenavigation.parse.parsers.ColorParser;
 import com.reactnativenavigation.parse.parsers.FractionParser;
+import com.reactnativenavigation.parse.parsers.NumberParser;
 import com.reactnativenavigation.parse.parsers.TextParser;
 import com.reactnativenavigation.utils.TypefaceLoader;
 
@@ -30,6 +31,7 @@ public static TitleOptions parse(TypefaceLoader typefaceManager, JSONObject json
         options.fontSize = FractionParser.parse(json, "fontSize");
         options.fontFamily = typefaceManager.getTypeFace(json.optString("fontFamily", ""));
         options.alignment = Alignment.fromString(TextParser.parse(json, "alignment").get(""));
+        options.height = NumberParser.parse(json, "height");
 
         return options;
     }

diff --git a/lib/android/app/src/test/java/com/reactnativenavigation/parse/OptionsTest.java b/lib/android/app/src/test/java/com/reactnativenavigation/parse/OptionsTest.java
@@ -25,6 +25,7 @@
 public class OptionsTest extends BaseTest {
 
     private static final String TITLE = "the title";
+    private static final Number TITLE_HEIGHT = new Number(100);
     private static final String FAB_ID = "FAB";
     private static final String FAB_ALIGN_HORIZONTALLY = "right";
     private static final String FAB_ALIGN_VERTICALLY = "bottom";
@@ -83,6 +84,7 @@ public void parsesJson() throws Exception {
     private void assertResult(Options result) {
         assertThat(result.topBar.title.text.get()).isEqualTo(TITLE);
         assertThat(result.topBar.background.color.get()).isEqualTo(TOP_BAR_BACKGROUND_COLOR);
+        assertThat(result.topBar.title.height.get()).isEqualTo(TITLE_HEIGHT.get());
         assertThat(result.topBar.title.color.get()).isEqualTo(TOP_BAR_TEXT_COLOR);
         assertThat(result.topBar.title.fontSize.get()).isEqualTo(TOP_BAR_FONT_SIZE);
         assertThat(result.topBar.title.fontFamily).isEqualTo(TOP_BAR_TYPEFACE);
@@ -134,6 +136,7 @@ private JSONObject createBackground() throws JSONException {
     private JSONObject createTitle() throws JSONException {
         return new JSONObject()
                 .put("text", "the title")
+                .put("height", TITLE_HEIGHT.get())
                 .put("color", TOP_BAR_TEXT_COLOR)
                 .put("fontSize", TOP_BAR_FONT_SIZE)
                 .put("fontFamily", TOP_BAR_FONT_FAMILY);