Add CLI parameter for overriding device name #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
requested changes
Aug 9, 2018
| @@ -45,6 +45,8 @@ program | |||
| '[Android Only] Launch Emulator in headless mode. Useful when running on CI.') | |||
| .option('-w, --workers <n>', | |||
| '[iOS Only] Specifies number of workers the test runner should spawn, requires a test runner with parallel execution support (Detox CLI currently supports Jest)', 1) | |||
| .option('-n, --device-name [name]', | |||
| 'Override the device name specified in a configuration. Useful for running a single build configuration on multiple devices.') | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, I'd forgotten about that. Done, thanks.
noomorph
reviewed
Aug 9, 2018
noomorph
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #875
This PR adds an extra command line param to
detox testto override the device name in a given configuration. This is handy for when you want to run a test for the same configuration across multiple devices. E.g: