fix: adds grep fallback for win32 #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
previously requested changes
Jul 25, 2018
detox/src/utils/pipeCommands.test.js
Outdated
| describe('search by regexp pipe command', () => { | ||
| const regexp = '^Hello\\s ".*"$'; | ||
|
|
||
| describe('on win32', () => { |
There was a problem hiding this comment.
These tests seem to test nothing. we already know what pipeUtils.search.regexp.win32 is. There's probably no need to rewrite the same logic in the test.
noomorph
force-pushed
the
noomorph/fixes-win32
branch
2 times, most recently
from
9a6698f
to
df68d8b
Compare
noomorph
force-pushed
the
noomorph/fixes-win32
branch
from
df68d8b
to
a27c3ab
Compare
|
This thread has been automatically locked to prevent bumping of old threads. Instead, if you believe the issue still reproduces, please open a new issue and provide all the required information. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last two pull requests have broken Win32 compatibility by piping some of the commands' outputs to
grepwhich is absent by default in the Windows environment.This pull request makes it possible to switch to
findstrcommand fallback ifprocess.platform === 'win32'.