Move generation to babel 7 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
changed the title
DanielMSchmidt
force-pushed
the
danielmschmidt/move-to-babel-7
branch
from
a6db945
to
f00a11b
Compare
DanielMSchmidt
changed the title
rotemmiz
reviewed
Jun 10, 2018
detox/src/devices/IosDriver.js
Outdated
| const GREYConfigurationApi = require('./../ios/earlgreyapi/GREYConfiguration'); | ||
| const GREYConfigurationDetox = require('./../ios/earlgreyapi/GREYConfigurationDetox'); | ||
| const EarlyGrey = require('./../ios/earlgreyapi/EarlGrey'); | ||
| const GREYConfigurationApi = require('./../ios/earlgreyapi/GREYConfiguration'); // eslint-disable-line node/no-unpublished-require |
There was a problem hiding this comment.
Please try to understand why this eslint doesn't like those lines. It makes no sense.
There was a problem hiding this comment.
I can remove it, should be red on master too, right 🤷♂️ The explanation with the npmignore makes kinda sense though
DanielMSchmidt
force-pushed
the
danielmschmidt/move-to-babel-7
branch
from
f00a11b
to
e84a29f
Compare
DanielMSchmidt
force-pushed
the
danielmschmidt/move-to-babel-7
branch
from
e84a29f
to
7101b78
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@DanielMSchmidt, can we go forward with this PR? Can you please rerun it on the updated code? |
|
Sure, it was just out of focus previously 👍 Will put it on my list to rerun the generation again. |
This enables us to generate better comments
DanielMSchmidt
force-pushed
the
danielmschmidt/move-to-babel-7
branch
from
7101b78
to
0a076cc
Compare
DanielMSchmidt
force-pushed
the
danielmschmidt/move-to-babel-7
branch
from
0a076cc
to
03e8df9
Compare
|
So is this ready? |
|
Yes it is👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have nicer comments in our generated code (and we need to do it anyways at some point).