Fix postinstall script of detox on sh
#723
Conversation
jhen0409
force-pushed
the
fix-script-linux
branch
from
dbeb538 to
8965333
Compare
detox/scripts/postinstall.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash -e | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
hey @jhen0409
Is there a reason you removed the -e flag ?
There was a problem hiding this comment.
It may unnecessary for the current case, but I'll add back it to be consistent. 👍
jhen0409
force-pushed
the
fix-script-linux
branch
from
8965333 to
071ac36
Compare
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash -e | |||
| #!/bin/sh -e | |||
There was a problem hiding this comment.
Why was this changed to sh from bash? Not saying bash is absolutely needed here, but I don't think there is a linux installation that comes without bash?
There was a problem hiding this comment.
Alpine Linux doesn't have bash by default (it is still installable), that's why it launch scripts by sh. We use it because its image size.
|
postinstall now uses node script to support Windows as well as Linux and macOS. |
Related to #627 (comment).
We can reproduce the issue by the following script: