Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a build matrix to support multiple version of React Native and OSs #345

Merged
merged 42 commits into from
Oct 18, 2017

Conversation

rotemmiz
Copy link
Member

@rotemmiz rotemmiz commented Oct 18, 2017

The end goal is to run a build matrix to support the following:

  • Multiple versions of React Native (latest and the version used internally at Wix)
  • Multiple versions of Xcode (currently 8.3.3 and 9, 8.3.3 will be dropped soon)
  • Add Android test suite to CI, including E2E and device control tests, on multiple OS versions, and preferably on Linux.

The current PR resolves the first two points.
Of course, a lot of CI Driven Development had to be done in order to understand what is supported in TravisCI and what's not (Hence CIDD commits)

@LeoNatan
Copy link
Contributor

LeoNatan commented Oct 18, 2017

I’d close this PR, it’s not written in …

TDD

Travis Driven Development



CC @DanielZlotin

@rotemmiz
Copy link
Member Author

Travis Driven Development is a kind of TDD

@rotemmiz rotemmiz merged commit 30eeefd into master Oct 18, 2017
@LeoNatan LeoNatan deleted the buildmatrix branch October 18, 2017 11:49
@DanielMSchmidt
Copy link
Contributor

Would it make sense for the next time to squash the commits and provide a meaningful commit message? It feels to me like git blame / history might be a problem for the files involved 😇 Just my humble opinion, no offence 👍 But great job, I hope we will spot a lot of errors with this 👍

@rotemmiz
Copy link
Member Author

Dear Mr. @DanielMSchmidt,
Every PR we accept is squashed before being merged to master, this one included.

@DanielMSchmidt
Copy link
Contributor

Ups, sorry, I didn't knew that and I must have missed this here :/ sorry to be the one writing incorrect and annoying comments :(

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants