Fix Android atIndex matcher by fixing typo #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
approved these changes
Oct 6, 2017
| @@ -218,7 +218,7 @@ class Element { | |||
| atIndex(index) { | |||
| if (typeof index !== 'number') throw new Error(`Element atIndex argument must be a number, got ${typeof index}`); | |||
| const matcher = this._originalMatcher; | |||
| this._originalMatcher._call = invoke.call(invoke.Android.Class(DetoxMatcher), 'matherForAtIndex', invoke.Android.Integer(index), matcher._call); | |||
| this._originalMatcher._call = invoke.call(invoke.Android.Class(DetoxMatcher), 'matcherForAtIndex', invoke.Android.Integer(index), matcher._call); | |||
There was a problem hiding this comment.
Great job 👍 @rotemmiz this is why generated code is superior 🏆 
There was a problem hiding this comment.
One thing: I could not find a test for this that was failing before. Not sure if this should have been caught or not ¯_(ツ)_/¯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in the name of the java method. It was 'matherForAtIndex' instead of 'matcherForAtIndex'