Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Android) Migrate instrumentation support lib to androidx libs #1193

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Mar 5, 2019


Description:

With respect to #1173 --
This is phase 1 of a 2-phase procedure towards fully migrating:

  1. Switch to androidx and provide a migration guide, bundled with the regeneration of the JS Espresso-contract classes based on this androidx test repo and tag
  2. Introduce the androidx test repo as a submodule and take the contracts from there, similar to what we already do with EarlGrey.

Reasons not to do step 2 right now are that this change is already pretty big as-is, and that step-2 will not be breaking in the users' perspective.

@d4vidi d4vidi self-assigned this Mar 5, 2019
@d4vidi d4vidi requested review from rotemmiz and LeoNatan March 5, 2019 13:17
@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 5, 2019

@LeoNatan @rotemmiz I need you guys to have a look at this - go over the docs, in the very least.

return downloadFile(
`http://android.googlesource.com/platform/frameworks/testing/+/android-support-test/espresso/core/src/main/java/${path}.java?format=TEXT`
);
return downloadFile(`https://raw.githubusercontent.com/android/android-test/androidx-test-1.1.0/espresso/core/java/${path}.java`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any new Google link to be used here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucasnlm, not sure I understand the question. This is a link to raw content of this repo: https://github.com/android/android-test

@d4vidi d4vidi merged commit 38644af into master Mar 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 16, 2019
@d4vidi
Copy link
Collaborator Author

d4vidi commented Mar 17, 2019

Update: I've decided to skip part 2 of this upgrade, as I don't see too much point in adding the submodule unless we effectively compile it along with Detox.
Currently the status is that the generator grabs the code from google's android-test repo on github from a tag that is perfectly aligned with the versions we use for the testing artifacts we defined as dependencies in our build.gradle. I find this to be suitable for what we need. See my inline comment for more details: https://github.com/wix/Detox/blob/master/detox/android/detox/build.gradle#L78

@LeoNatan LeoNatan deleted the androidx-upgrade branch July 22, 2019 02:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants